Skip to content

Codex Cli Start Delay#647

Merged
arul28 merged 1 commit into
mainfrom
ade/see-screenshot-after-submitting-emssage-749c4815
Jun 24, 2026
Merged

Codex Cli Start Delay#647
arul28 merged 1 commit into
mainfrom
ade/see-screenshot-after-submitting-emssage-749c4815

Conversation

@arul28

@arul28 arul28 commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

Describe the change.

What Changed

Key files and behaviors.

Validation

How you tested.

Risks

Anything to watch.

ADE   Open in ADE  ·  ade/see-screenshot-after-submitting-emssage-749c4815 branch  ·  PR #647

Summary by CodeRabbit

  • Bug Fixes
    • Improved launch instructions so they now adapt to whether a task prompt was provided.
    • When a prompt is present, the app now tells the CLI to begin work right away.
    • When no prompt is provided, the app now waits for the next user instruction before taking action.

Greptile Summary

This PR updates CLI launch guidance for sessions with and without an initial prompt. The main changes are:

  • Adds separate ADE preamble text for idle launches and prompted launches.
  • Tells prompted CLI sessions to start on the supplied user prompt immediately.
  • Adds Codex tests for empty launches and initial-prompt launches.

Confidence Score: 5/5

The change is narrowly scoped to CLI launch guidance and accompanying tests, with no accepted correctness concerns.

The modified behavior is covered by targeted tests for empty and initial-prompt launches, and no issues were identified in the changed files.

T-Rex T-Rex Logs

What T-Rex did

  • Ran a test with a user prompt block present and observed that the base launch emitted wait guidance.
  • Verified that the head launch preserves wait guidance for an empty launch and switches a prompted launch to immediate-start guidance.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Fix Codex CLI initial prompt handling" | Re-trigger Greptile

@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ade Ignored Ignored Jun 24, 2026 7:28pm

@arul28

arul28 commented Jun 24, 2026

Copy link
Copy Markdown
Owner Author

@copilot review but do not make fixes

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The CLI launch preamble now varies ADE session guidance based on whether an initial prompt is present, and the Codex launch tests assert both the waiting and immediate-work variants in launch.initialInput.

Changes

Codex CLI launch guidance

Layer / File(s) Summary
Initial-prompt-aware guidance and assertions
apps/desktop/src/shared/cliLaunch.ts, apps/desktop/src/renderer/components/terminals/cliLaunch.test.ts
workTabCliPreamblePrompt now chooses between waiting and immediate-work guidance from hasInitialPrompt, workTabCliPrompt passes Boolean(initialPrompt), and Codex launch tests assert the matching launch.initialInput content.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

desktop

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is related to the main change: Codex CLI now delays action when there is no initial prompt and starts immediately when there is one.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ade/see-screenshot-after-submitting-emssage-749c4815

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mintlify

mintlify Bot commented Jun 24, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
ade-ac1c6011 🟢 Ready View Preview Jun 24, 2026, 7:29 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant