Skip to content

fix: validate length parameter value and use avg month calculation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hitchhiker007 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: validate length parameter value and use avg month calculation #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ function timelydiff(timestamp, length = null) {
if (length !== null && typeof length !== "string") {
throw new Error("Invalid length parameter.");
}
// check if the length type provided is a string and if the value is valid
if (length !== null && length !== "short" && length !== "shorter") {
throw new Error("Invalid length parameter. Use null, 'short', or 'shorter'.");
}

//Calculate the time difference between the current time and the timestamp, in seconds.
let timeDifference = (Date.now() - timestamp) / 1000;
Expand All @@ -35,7 +39,7 @@ function timelydiff(timestamp, length = null) {
[{ short: "h", def: "hour" }, Math.round(timeDifference / 3600), 24],
[{ short: "d", def: "day" }, Math.round(timeDifference / 86400), 7],
[{ short: "w", def: "week" }, Math.round(timeDifference / 604800), 4],
[{ short: "mo", def: "month" }, Math.round(timeDifference / 2419200), 12],
[{ short: "mo", def: "month" }, Math.round(timeDifference / 2629800), 12], // now avg is 30.44 days
[{ short: "y", def: "year" }, Math.round(timeDifference / 29030400), 10],
[
{ short: "dcd", def: "decade" },
Expand Down