ci: Fix errors#461
Merged
Merged
Conversation
…recation lean-test now compiles everything with warnings-as-errors: - lean-action builds the default target with --wfail (warms cache, checks lib) - `lake lint -- --wfail -v` runs the @[lint_driver] build-all script, building every lib/exe target (exes, benchmarks, Apps) under --wfail - both `lake test` steps run with --wfail Replace deprecated `String.dropRight` with `String.dropEnd` in ProfileCmd and ShardCmd — the deprecation these strict builds now catch.
arthurpaulino
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Zisk execution cfg errors from
riscv-bench.yml, and thelake build ixfailure frombench-main.yml. The latter was not caught inci.ymlbecause it didn't pass--wfailtolake test -- cli, so I added--wfailto all build steps inci.ymlto catch this onpull_request.