LwipServer - manage connections as LwipClient so a copy always exists for shared_ptr - #210
Open
JAndrassy wants to merge 1 commit into
Open
LwipServer - manage connections as LwipClient so a copy always exists for shared_ptr#210JAndrassy wants to merge 1 commit into
JAndrassy wants to merge 1 commit into
Conversation
JAndrassy
marked this pull request as draft
December 15, 2023 16:27
JAndrassy
force-pushed
the
lwipclient_shared_ptr_with_server
branch
from
December 15, 2023 16:30
4f02c81 to
af09d06
Compare
JAndrassy
marked this pull request as ready for review
December 15, 2023 21:43
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the changes discussed in #207
what do you think?
If this is not merged, I can do a separate PR for the Wifi/Ethernet Client and Server changes. They reduce code duplication. Maybe even the 'facades' could be only a typedef like
typedef lwipClient WiFiClient, but I am not sure about all consequences of changing a class to a typedef.