feat(APP-942): Finish permissions graph view with real data#1238
feat(APP-942): Finish permissions graph view with real data#1238thekidnamedkd wants to merge 20 commits into
Conversation
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
milosh86
left a comment
There was a problem hiding this comment.
Looks great, left some housekeeping comments.
milosh86
left a comment
There was a problem hiding this comment.
Great job 🙌 I've just tested it and it looks great!
One usage feedback, not related to implementation: Unknown address is not really helpful. You need to click to see which address is that, but it could be handy to have truncated address as a label instead.
Yes great feedback. I had it the other way briefly as well Jordi said the two felt kind of redundant want and he preferred the parity of a detail inspect pop out, but let's see what consensus is. This is still kind of discovery mode when it comes to the "feel" stuff. |
52cd8cf to
56f228c
Compare
Description
Finishes the permissions graph view work under APP-942, replacing the earlier APP-967 graph PR (#1202). The scope shifted from a preview/mock graph into the real permissions surface backed by the app-backend relationship payload.
-, unresolved condition addresses show as unrecognized instead of being hiddenPreview path for validation:
/dao/citrea-mainnet/0xA941b1C1D9aDC88C9241aA3ACA59E8B8f0386419/settings/permissionsAdd
?permissionsview=graphto open the graph directly.Provenance
Supersedes #1202 / APP-967. APP-967 became a duplicate once the work moved under APP-942 and the backend contract from aragon/app-backend#1439 became the real source of permission relationships. This PR keeps the useful graph work from #1202, ports it into the monorepo shape, removes the preview/mock path, and finishes the view against the live permissions payload.
Type of Change
Developer Checklist:
Review Checklist: