PostgreSQL Percona pg_tde (TDE) image support - #109
Merged
Conversation
Adds a tde.json variant alongside app.json/dhi.json/ext.json: a tag whose last '-' segment is 'percona' now resolves to library/<name>/tde.json, the same way '-ext' resolves to ext.json (#91). First block is 17.9-percona, built from tde/17.9/bookworm in appscode-images/postgres. The Dockerfile installs Percona Server for PostgreSQL 17.9 plus pg_tde while keeping the postgres:17-bookworm runtime contract KubeDB relies on. Only amd64 and arm64 are listed since Percona publishes ppg-17 for those two. The tag is registered in both build_tags.txt (the list cmd/generate-workflows renders the matrix from and cmd/mail-report walks for the CVE report) and the build-postgres workflow matrix. Postgres repo commit: appscode-images/postgres@f0fc44a Signed-off-by: souravbiswassanto <saurov@appscode.com>
souravbiswassanto
force-pushed
the
postgres-tde
branch
from
August 7, 2026 15:04
b6160e0 to
85d3f16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up a Percona /
pg_tdeimage variant for postgres, mirroring how-extwas added in #91. First tag is
17.9-percona.Changes
cmd/build-image/main.go—FindBlockgains aperconacase, so a tagwhose last
-segment isperconaresolves tolibrary/<name>/tde.json(alongside the existing
dhi.json/ext.json/app.jsoncases).library/postgres/tde.json— one block:17.9-percona, built fromtde/17.9/bookwormatappscode-images/postgres@f0fc44a..github/workflows/build-postgres.yml—17.9-perconaadded to the buildmatrix, next to the
17.9-*-exttags.library/postgres/build_tags.txt— same tag added here too. This is thelist
cmd/generate-workflowsrenders$tags$from and the onecmd/mail-reportwalks for the CVE report, so the workflow matrix entry onlysurvives a workflow regeneration if the tag is here as well.
Result:
ghcr.io/appscode-images/postgres:17.9-percona.Why
KubeDB's Transparent Data Encryption support needs Percona's
pg_tde, whosetde_heapaccess method requires the Percona Server for PostgreSQL fork ratherthan community PostgreSQL. So TDE needs its own image rather than an extension
layered on top of
postgres:<major>-bookworm. The Dockerfile still keeps thesame runtime contract (uid/gid 999, binaries under
/usr/lib/postgresql/17/bin,upstream entrypoint + gosu, same
PGDATA/locale/VOLUME/STOPSIGNAL/EXPOSE),so the existing KubeDB run scripts work against it unchanged.
Architectures
tde.jsonlists onlyamd64andarm64v8— Percona publishesppg-17foramd64,arm64andi386only, and the builder filters to amd64/arm64 anyway.Both are present in
repo.percona.com/ppg-17/apt(bookworm) and in theghcr.io/appscode-images/postgres:17.9-bookwormdonor manifest.Verified
go build ./...andgo vet ./cmd/build-image/clean17.9-percona→tde.json(dir=tde/17.9/bookworm,commit=f0fc44a,2 architectures), while
17.9-bookworm-extstill resolves toext.jsonand17.9-bookwormstill resolves toapp.jsonlinux/amd64and reportspostgres (PostgreSQL) 17.9 - Percona Server for PostgreSQL 17.9.1, withpg_tde.controlinstalled andpg_tde_basebackup/pg_tde_rewind/pg_tde_waldump/pg_tde_resetwalall executableNote on naming
The tag is
17.9-percona(no distro segment) while the Dockerfile lives attde/17.9/bookworm— the directory keeps the<variant>/<version>/<distro>layout the
ext/dhitrees use, and the manifest file staystde.jsonsince itis keyed by capability rather than vendor. Say the word if you'd rather the
directory or file follow the tag name instead.
Pre-existing gap, not fixed here
The six
-exttags and the-dhitags were never added tolibrary/postgres/build_tags.txt, so runningcmd/generate-workflowstodaywould drop them from the matrix (and also revert
runs-on: firecrackerand thepinned action SHAs). Happy to add them in this PR if you want that cleaned up at
the same time.
Postgres repo PR: appscode-images/postgres#1 (branch
tdeis already pushed, sothe commit
f0fc44areferenced above is fetchable now).