Skip to content

Add sample values for ace and ace-installer charts - #1318

Merged
ArnobKumarSaha merged 1 commit into
masterfrom
arnob-sample-vals
Aug 16, 2026
Merged

Add sample values for ace and ace-installer charts#1318
ArnobKumarSaha merged 1 commit into
masterfrom
arnob-sample-vals

Conversation

@ArnobKumarSaha

Copy link
Copy Markdown
Member

Problem

image-packer list --root-dir=charts renders each chart with default values only, plus <chart>/ci/ci-values.yaml and <chart>/*.sample.yaml when those exist (image.go:72-108). charts/ace had neither, and nats.enabled / openfga.enabled default to false, so those subcharts never rendered and their images never reached catalog/imagelist.yaml:

  • ghcr.io/appscode/openfga
  • ghcr.io/appscode-images/nats
  • ghcr.io/appscode/k8s-wait-for

Fix

*.sample.yaml is matched by image-packer's glob but is not consumed by ct / helm install, unlike ci/ci-values.yaml — so chart-testing behavior is unchanged.

charts/ace/ace.sample.yaml

Enables every optional subchart and mirrors the registry/tag overrides that lib-selfhost applies to a real deployment (values taken from a downloaded offline installer, with all secrets, hosts, JWTs and CA material stripped).

Notable: openfga.datastore.engine: postgres is required — with the default engine the migrate Job and its wait-for-migration init container are skipped, so k8s-wait-for never renders. Setting datastoreURI alone is not enough.

Not included: nats.bootconfig (natsio/nats-boot-config) never renders, as it needs nats.externalAccess + advertise, both off in a real install.

charts/ace-installer/ace-installer.sample.yaml

Turns on every helm.releases.* entry that defaults to false. Verified this adds no images today — the chart only emits HelmRelease CRs plus precheck/regcache/test — but it keeps future per-release template changes covered automatically.

Result

hack/scripts/update-catalog.sh now adds 13 images to catalog/imagelist.yaml, including all three that were missing:

+ ghcr.io/appscode-images/ingress-nginx-controller:v1.15.1
+ ghcr.io/appscode-images/nats:2.12.6-alpine
+ ghcr.io/appscode/k8s-wait-for:v2.0
+ ghcr.io/appscode/openfga:v1.11.3
+ ghcr.io/appscode/pgoutbox:v0.0.4
+ ghcr.io/appscode/prom-authproxy:v0.0.2
+ ghcr.io/appscode/trickster:v2.0.0
+ ghcr.io/cloudoperators/greenhouse-extensions-integration-test:main
+ ghcr.io/opnpulse/perses:v2026.4.24
+ ghcr.io/voyagermesh/defaultbackend:1.5
+ natsio/nats-box:0.13.8
+ natsio/nats-server-config-reloader:0.22.3
+ natsio/prometheus-nats-exporter:0.19.2

Notes for reviewers

  • Two helm test-hook images land in the catalog (natsio/nats-box, greenhouse-extensions-integration-test). nats-box renders regardless of natsbox.enabled. Accepted as harmless — a superset catalog beats a silently incomplete one.
  • The tags pinned here (nats 2.12.6-alpine, reloader 0.22.3, exporter 0.19.2, prom-authproxy v0.0.2) duplicate lib-selfhost and will need a bump when it bumps them.
  • make add-license fmt could not run locally (needs a Docker daemon), and generate-scripts hit BSD date / find -printf incompatibilities on macOS, which rewrote catalog/*.sh. Those five files were reverted, so the only generated change in this PR is imagelist.yaml. Worth re-running make refresh on Linux to confirm nothing else drifts.

image-packer renders each chart with default values plus any *.sample.yaml,
so subcharts disabled in values.yaml never contribute images to the catalog.
ghcr.io/appscode/openfga, ghcr.io/appscode-images/nats and
ghcr.io/appscode/k8s-wait-for were missing for this reason.

Enable the optional subcharts and mirror the registry/tag overrides that
lib-selfhost applies to a real deployment. openfga needs a sql datastore
engine, otherwise the migrate Job and its wait-for-migration init container
are skipped and k8s-wait-for never renders.

The ace-installer sample adds no images today, since the chart only emits
HelmRelease CRs, but keeps future per-release templates covered.

Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
@ArnobKumarSaha
ArnobKumarSaha merged commit f78c533 into master Aug 16, 2026
4 of 5 checks passed
@ArnobKumarSaha
ArnobKumarSaha deleted the arnob-sample-vals branch August 16, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant