Add sample values for ace and ace-installer charts - #1318
Merged
Conversation
image-packer renders each chart with default values plus any *.sample.yaml, so subcharts disabled in values.yaml never contribute images to the catalog. ghcr.io/appscode/openfga, ghcr.io/appscode-images/nats and ghcr.io/appscode/k8s-wait-for were missing for this reason. Enable the optional subcharts and mirror the registry/tag overrides that lib-selfhost applies to a real deployment. openfga needs a sql datastore engine, otherwise the migrate Job and its wait-for-migration init container are skipped and k8s-wait-for never renders. The ace-installer sample adds no images today, since the chart only emits HelmRelease CRs, but keeps future per-release templates covered. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
image-packer list --root-dir=chartsrenders each chart with default values only, plus<chart>/ci/ci-values.yamland<chart>/*.sample.yamlwhen those exist (image.go:72-108).charts/acehad neither, andnats.enabled/openfga.enableddefault tofalse, so those subcharts never rendered and their images never reachedcatalog/imagelist.yaml:ghcr.io/appscode/openfgaghcr.io/appscode-images/natsghcr.io/appscode/k8s-wait-forFix
*.sample.yamlis matched by image-packer's glob but is not consumed byct/helm install, unlikeci/ci-values.yaml— so chart-testing behavior is unchanged.charts/ace/ace.sample.yamlEnables every optional subchart and mirrors the registry/tag overrides that lib-selfhost applies to a real deployment (values taken from a downloaded offline installer, with all secrets, hosts, JWTs and CA material stripped).
Notable:
openfga.datastore.engine: postgresis required — with the default engine the migrate Job and itswait-for-migrationinit container are skipped, sok8s-wait-fornever renders. SettingdatastoreURIalone is not enough.Not included:
nats.bootconfig(natsio/nats-boot-config) never renders, as it needsnats.externalAccess+advertise, both off in a real install.charts/ace-installer/ace-installer.sample.yamlTurns on every
helm.releases.*entry that defaults to false. Verified this adds no images today — the chart only emits HelmRelease CRs plus precheck/regcache/test — but it keeps future per-release template changes covered automatically.Result
hack/scripts/update-catalog.shnow adds 13 images tocatalog/imagelist.yaml, including all three that were missing:Notes for reviewers
natsio/nats-box,greenhouse-extensions-integration-test).nats-boxrenders regardless ofnatsbox.enabled. Accepted as harmless — a superset catalog beats a silently incomplete one.2.12.6-alpine, reloader0.22.3, exporter0.19.2, prom-authproxyv0.0.2) duplicate lib-selfhost and will need a bump when it bumps them.make add-license fmtcould not run locally (needs a Docker daemon), andgenerate-scriptshit BSDdate/find -printfincompatibilities on macOS, which rewrotecatalog/*.sh. Those five files were reverted, so the only generated change in this PR isimagelist.yaml. Worth re-runningmake refreshon Linux to confirm nothing else drifts.