e2e tests: run with podman as well as docker#178
Open
krishnapermi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52
Adds
podmanas a second container runtime to the end-to-end test matrix, alongside the existingdockerjobs.Changes
runtime: [docker, podman]as a new matrix dimension inendtoend_tests.ymlmatrix.runtime == 'podman') that registerslocalhost:5000as an insecure registry in/etc/containers/registries.conf.d/. Podman rejects plain-HTTP registries by default, so this step is necessary for the localregistry:2service used in CI.docker runin the "Run the example" step with${{ matrix.runtime }} run, so the same step exercises both runtimes.The step name also includes
${{ matrix.runtime }}to make it easy to distinguish docker vs podman runs in the Actions UI.I spotted this while looking through the open issue list after submitting previous PRs. Podman is pre-installed on ubuntu-latest, and since the test already pushes to a local registry and pulls from it at run time, switching the pull/run step to use podman should be a faithful compatibility check with no other changes needed.