Dereference symlinked config before copying#1944
Open
tiferrei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
When
~/.config/container/config.tomlis a symbolic link,FileManager.copyItempreserves the link when copying it into the application support directory. This causes the runtime configuration snapshot to remain tied to the original file, which is problematic for declaratively managed, read-only configurations such as those installed through Nix.Resolve the source path before copying so the application support configuration is always an independent file.
Testing
Added a regression test that verifies a symlinked source produces a regular destination that remains readable after removing the source target. The test fails without the fix, and the full test suite passes with it.