Skip to content

Upgrade tmp package to 0.2.7 - #256

Closed
akaustav wants to merge 3 commits into
apigee:masterfrom
akaustav:ak-fix-255
Closed

Upgrade tmp package to 0.2.7#256
akaustav wants to merge 3 commits into
apigee:masterfrom
akaustav:ak-fix-255

Conversation

@akaustav

@akaustav akaustav commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

Change Summary

This pull request updates the version of the tmp dependency in the package.json file from version ^0.0.27 to ^0.2.7. Among other things, this update includes the fix for the following security problems - as mentioned in issue #255:

Commands Used

The following commands were used to create the changes in this PR:

npm i
npm r tmp
npm i tmp

Additional Notes

  • One of the previous commits on the master branch updated package.json to version 0.16.6 but didn't update package-lock.json. Running npm i syncs package-lock.json with the new version. This PR includes that update.
  • The caret (^) prefix in semantic versioning only matches patch versions for 0.0.x releases (unlike versions >= 1 which match both minor and patch versions). So ^0.0.27 will not automatically pick up version 0.2.5.
  • The security fix for GHSA-52f5-9888-hmc6 exists in tmp version 0.2.4, but the second commit on this PR uses the latest 0.2.5 (published August 8, 2025).
  • Update 2026-07-29: The security fix for GHSA-ph9p-34f9-6g65 exists in tmp version 0.2.6, but the third commit on this PR uses the latest 0.2.7 (published May 27, 2026).

@akaustav

akaustav commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

@DinoChiesa / Maintainers - I am not sure why the Google GitHub Admin: Actions Workflow Security Scan GitHub Action is pending. Please assist.

@kevya-google

Copy link
Copy Markdown

@DinoChiesa / Maintainers - I am not sure why the Google GitHub Admin: Actions Workflow Security Scan GitHub Action is pending. Please assist.

Hi @akaustav, you should be able to merge the PR without waiting for the checks or if it's somehow blocking, you can re-push to update the branch to re-trigger them. Thanks!

@akaustav

Copy link
Copy Markdown
Contributor Author

Hi @akaustav, you should be able to merge the PR without waiting for the checks or if it's somehow blocking, you can re-push to update the branch to re-trigger them. Thanks!

@kevya-google - Thanks for responding. I am unable to see the Merge button on this PR. Also, with my level of access, I am able to see PR checks shown in the image below as still "In Progress".

image

@akaustav

Copy link
Copy Markdown
Contributor Author

Hi @akaustav, you should be able to merge the PR without waiting for the checks or if it's somehow blocking, you can re-push to update the branch to re-trigger them. Thanks!

@kevya-google - On a side note, I saw @rakesh-talanki opened PR #265 with another commit bumping tmp from ^0.2.5 to ^0.2.7 for GHSA-ph9p-34f9-6g65 (CVE-2026-44705). I believe tmp@^0.2.5 should already include version 0.2.7 (and generally any version <0.3.0, since 0.x version ranges behave differently). With my current repo access, I can see only one pending check on that PR (as shown below). Since I wasn’t sure what "re-push to update the branch" meant, I plan to make the same change on my branch and check whether any pending checks appear on this PR; if I do, I'll follow up for guidance.

Pending checks on @rakesh-talanki's PR #265

image

@akaustav akaustav changed the title Upgrade tmp package to 0.2.5 Upgrade tmp package to 0.2.7 Jul 29, 2026
@akaustav

Copy link
Copy Markdown
Contributor Author

@kevya-google - I was able to make the next change and now I see two successful checks and one pending check on this PR (similar to the checks on @rakesh-talanki's PR #265) without a Merge button. Please advise.

image

@kevya-google

Copy link
Copy Markdown

@kevya-google - I was able to make the next change and now I see two successful checks and one pending check on this PR (similar to the checks on @rakesh-talanki's PR #265) without a Merge button. Please advise.

Hi, I've manually approved the security scan workflow to run on both #256 and #265. The workflows require approval from a maintainer because these PRs are created using personal forks instead of branches.

@akaustav

Copy link
Copy Markdown
Contributor Author

Hi, I've manually approved the security scan workflow to run on both #256 and #265. The workflows require approval from a maintainer because these PRs are created using personal forks instead of branches.

@kevya-google - Thanks for approving the pending check. I'm not a maintainer of this repository and had to use a personal fork, so I can't see the Merge button even though all three PR checks are passing now. Please advise.

rakesh-talanki added a commit that referenced this pull request Jul 30, 2026
PR #256 previously bumped this dependency to 0.2.5, which successfully patched the Symlink vulnerability (CVE-2025-54798). However, the Path Traversal vulnerability (CVE-2026-44705) via prefix/postfix parameters was only recently patched in version 0.2.7.

This update bumps the dependency to ^0.2.7 to ensure both CVEs are comprehensively remediated.

Test Suite: 91 specs, 0 failures.
@kevya-google

Copy link
Copy Markdown

@kevya-google - Thanks for approving the pending check. I'm not a maintainer of this repository and had to use a personal fork, so I can't see the Merge button even though all three PR checks are passing now. Please advise.

It looks like #265 merged by @rakesh-talanki which merged the changes from this PR so you can safely close this now. I don't have a workaround for you apart from contacting repository members to help merge future changes.

@akaustav

akaustav commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

It looks like #265 merged by @rakesh-talanki which merged the changes from this PR so you can safely close this now. I don't have a workaround for you apart from contacting repository members to help merge future changes.

@kevya-google - Understood. Thanks for the update. I am closing this PR because:

  1. it is effectively a duplicate of @rakesh-talanki's PR Fix/tmp security patch #265, and
  2. @rakesh-talanki's PR Fix/tmp security patch #265 has now been merged into the master branch of this repository.

@kevya-google - Would you know how to release this fix into the corresponding npm package hosted at the following URL? https://www.npmjs.com/package/apigeetool

@akaustav akaustav closed this Jul 30, 2026
@akaustav
akaustav deleted the ak-fix-255 branch July 30, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants