Skip to content

fix: ensure the committed changelog ends with a trailing newline #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vdusek wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: ensure the committed changelog ends with a trailing newline #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/python_bump_and_update_changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,15 @@ jobs:
write-mode: overwrite
contents: ${{ inputs.changelog }}

# The 'changelog' input travels through a $GITHUB_OUTPUT heredoc, which strips the trailing
# newline, so the input path above writes the file without one. Normalize here so the committed
# changelog always ends with a newline, whichever path wrote it.
- name: Ensure the changelog ends with a newline
shell: bash
env:
CHANGELOG_PATH: ${{ inputs.changelog_path }}
run: sed -i -e '$a\' "${CHANGELOG_PATH}"

- name: Commit changes
id: commit
uses: apify/actions/signed-commit@v1.0.0
Expand Down
Loading