chore: bump ngx_http_ffi_client to v0.1.2 - #485
Merged
Conversation
v0.1.1 carried no source changes over v0.1.0, so the runtime still ships the three defects found while moving the AI plugins onto the client: request bodies containing CR or LF are rejected, connection errors are logged at error level despite lua_socket_log_errors off, and the trust store ignores lua_ssl_trusted_certificate, which fails every verified TLS connection on a runtime with a bundled OpenSSL.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe runtime build script now uses ChangesRuntime dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
nic-6443
approved these changes
Aug 10, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v0.1.1was a licensing and packaging release: overv0.1.0it adds a LICENSE, a README section and aconfigtweak, and the C sources are byte-identical. So the runtime still carries the three defects found while moving the AI plugins onto this client (apache/apisix#13778, api7/api7-ee-3-gateway#2075):invalid request. Any caller posting pretty-printed JSON gets a 500 when the body is forwarded verbatim.lua_socket_log_errors off, which APISIX sets. Refused and reset upstreams are routine for an AI gateway, so this is steady error-log noise.lua_ssl_trusted_certificateand relies on OpenSSL's default verify paths, which are empty in anapisix-runtimebuild. Every verified TLS connection fails unless the call site passes a CA explicitly, so the client cannot reach any HTTPS LLM provider as shipped.All three are fixed in
v0.1.2.Verification
A runtime built from these three fixes was exercised on an API7 EE gateway proxying to real Azure OpenAI, comparing
ngx_http_ffi_clientagainstlua-resty-httpon the same routes:[DONE][DONE]Three protocol adapters (
openai-chat,openai-responses,anthropic-messages), TLS with SNI, streaming, retry and connection reuse. Before the fixes the same gateway returned 500TLS certificate verify failedon every one of these.The build itself also covers api7/ngx_http_ffi_client#43's compat shim: this script exports
NGX_HTTP_LUA_MODULE_DIRpointing at the pristine bundledngx_lua-*, which is the configured-checkout casesrc/compat/ngx_http_lua_autoconf.hexists for. It compiles clean.Next
A runtime release on top of this, so
apache/apisix#13778andapi7/api7-ee-3-gateway#2075can pin a runtime that actually carries the fixes.1.3.13and1.3.14both pinv0.1.1.Summary by CodeRabbit