TEZ-4727: Add ARM support of the dependent leveldbjni#509
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
minor question: could the aarch64 build success be validated by a github action? |
|
@abstractdog I have added in the github actions the ARM support: https://github.com/apache/tez/actions/runs/27742306971/job/82072186429?pr=509 Have to skip the UI build it is broken due to PhantomJS, Have to chase it seprately maybe migrate to |
|
💔 -1 overall
This message was automatically generated. |
okay! there is only a yamllint warning left |
|
💔 -1 overall
This message was automatically generated. |
|
Thanx @abstractdog for the review, Have fixed the yamlint warning |
abstractdog
left a comment
There was a problem hiding this comment.
+1 more nit, other than that LGTM
| if (e instanceof IOException) { | ||
| throw (IOException) e; |
There was a problem hiding this comment.
what about simply skipping this check, the next line takes care of wrapping it into an IOException anyway
|
💔 -1 overall
This message was automatically generated. |
Description in Jira