Conversation
As tests run in production mode by default, a valid passphrase must be present.
thiagohp
approved these changes
Jul 18, 2026
benweidig
added a commit
that referenced
this pull request
Jul 19, 2026
…ase (#63) * Hmac passphrase rules were improved (incl. min length of 20) * Prevent startup in production mode if weak/empty passphrase * PageTesterModule sets HMAC passphrase to not fail during testing * ClientDataEncoderImplTest: Groovy -> Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a more strict HMAC passphrase validation, requiring a length of at least 20 characters.
In PRODUCTION, this is now a hard failure, preventing startup.
In NON-PRODUCTION, it remains a "loud" error, logging to level "error" and using the AlertManager to display the message.
The fallback passphrase is now a random UUID instead of the app package name.
Furthermore, the tests were converted from Groovy to Java.