PHOENIX-7954 Update phoenix-adapters to use latest 5.3.2 phoenix#11
Merged
Conversation
Bump <phoenix.version> from 5.3.1 to 5.3.2 now that Apache Phoenix 5.3.2 is released and available on Maven Central. Verified locally with a full 'mvn clean install' (Central-direct): all modules compile and package against 5.3.2 and the unit + integration suites pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
<phoenix.version>inpom.xmlfrom 5.3.1 → 5.3.2, now that Apache Phoenix 5.3.2 has been released and published to Maven Central.JIRA: PHOENIX-7954
Changes
pom.xml(line 46):<phoenix.version>5.3.1</phoenix.version>→<phoenix.version>5.3.2</phoenix.version>All consumed Phoenix artifacts (
phoenix-core,phoenix-core-client,phoenix-core-server,phoenix-hbase-compat-2.5.4) resolve at${phoenix.version}and are available at 5.3.2 on Maven Central.Verification
Full
mvn clean installlocally against Maven Central: all modules (phoenix-ddb-utils,phoenix-ddb-rest,phoenix-ddb-assembly,coverage-report) compile and package cleanly against 5.3.2; the suite runs 1011 tests with 0 errors.The only failing test is
GetRecordsIT.testGetRecordsWithPartitionSplits, which is a pre-existing, flaky, order-sensitive test-harness issue — not a product regression, not a data-integrity issue, and not attributable to this version bump. Evidence:TestUtils.validateRecordsasserts record-set size equality first (TestUtils.java:231) and only then compareskeys()index-by-index (:244). Failures land on the index compare, so both streams return an equal number of records — one position is merely out of order (both PK pairs are well-formed consecutive values the test itself generated).approximateCreationDateTimealone, with no tiebreaker (GetRecordsIT.java:427,:438). That timestamp is coarse (whole-second granularity), so many records tie; a deterministic total-order key (sequenceNumber) exists on every record but the sort ignores it. Tied records legitimately order differently between the single-shard DynamoDB scan and the multi-shard Phoenix concatenation under partition splits.CDCVersionFilter), which returns onlyINCLUDE/SKIP/NEXT_COLand is per-row scoped — an HBase filter cannot reorder the scan stream, and any defect there would surface atoldImage()/newImage(), notkeys().The permanent fix belongs in the test, not this PR: add a
sequenceNumbertiebreaker to both sorts (.thenComparing(...)atGetRecordsIT.java:427and:438) so the comparison is order-deterministic. Tracked separately from this version bump.