Make action container tests resolve container IP on Docker Engine v29+ - #5583
Open
dorbae wants to merge 1 commit into
Open
Make action container tests resolve container IP on Docker Engine v29+#5583dorbae wants to merge 1 commit into
dorbae wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ActionContainer.withContainerdiscovers a freshly started action container's IP withdocker inspect --format '{{range.NetworkSettings.Networks}}{{.IPAddress}}{{end}}'. Because the top-level network properties ofNetworkSettingswere removed in Docker Enginev29.0.0(APIv1.52).rangeis used rather than hard-coding.Networks.bridge.IPAddressso the lookup does not assume anetwork name. Containers created by
createContainer()are started without--networkand thereforejoin exactly one network, so the range yields a single address.
Related issue and scope
NetworkSettings.IPAddressremoved) #5582)My changes affect the following components
Types of changes
Checklist: