Skip to content

Make action container tests resolve container IP on Docker Engine v29+ - #5583

Open
dorbae wants to merge 1 commit into
apache:masterfrom
dorbae:docker-inspect
Open

Make action container tests resolve container IP on Docker Engine v29+#5583
dorbae wants to merge 1 commit into
apache:masterfrom
dorbae:docker-inspect

Conversation

@dorbae

@dorbae dorbae commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

ActionContainer.withContainer discovers a freshly started action container's IP with
docker inspect --format '{{range.NetworkSettings.Networks}}{{.IPAddress}}{{end}}'. Because the top-level network properties of NetworkSettings were removed in Docker Engine v29.0.0 (API v1.52).

range is used rather than hard-coding .Networks.bridge.IPAddress so the lookup does not assume a
network name. Containers created by createContainer() are started without --network and therefore
join exactly one network, so the range yields a single address.

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant