NUTCH-3187 - protocol-okhttp: IP address filter fails to compare first byte for /32 resp. /128 CIDRs#929
Merged
sebastian-nagel merged 1 commit intoJul 7, 2026
Conversation
sebastian-nagel
commented
Jun 16, 2026
sebastian-nagel
commented
Contributor
- Fix the CIDR matching issue described in NUTCH-3187 resp. #1107 - Add okhttp IP address filter stormcrawler#1942.
- Add unit tests.
- Code improvements:
- make fields final
- use function references instead of lambda expressions
sebastian-nagel
force-pushed
the
NUTCH-3187-okhttp-cidr
branch
from
1251d99 to
55e8ff1
Compare
…t byte for /32 resp. /128 CIDRs
sebastian-nagel
force-pushed
the
NUTCH-3187-okhttp-cidr
branch
from
55e8ff1 to
d887611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.