MINIFICPP-2845 - Monotonic provenance event identifiers, iterations support, refactor#2209
Draft
adamdebreceni wants to merge 4 commits into
Draft
MINIFICPP-2845 - Monotonic provenance event identifiers, iterations support, refactor#2209adamdebreceni wants to merge 4 commits into
adamdebreceni wants to merge 4 commits into
Conversation
8 tasks
szaszm
reviewed
Jul 6, 2026
| } | ||
|
|
||
| Identifier& Identifier::operator++() { | ||
| for (int byte_idx = 15; byte_idx >= 0 && ++data_[byte_idx] == 0; --byte_idx) {} |
Member
There was a problem hiding this comment.
This is a bit too dense and clever for my liking, I'd separate the iteration from the rest of the increment + carry logic.
Suggested change
| for (int byte_idx = 15; byte_idx >= 0 && ++data_[byte_idx] == 0; --byte_idx) {} | |
| // increment with carry | |
| for (int byte_idx = 15; byte_idx >= 0; --byte_idx) { | |
| ++data_[byte_idx]; | |
| if (data_[byte_idx] != 0) { | |
| break; | |
| } | |
| } |
| class SchedulingAgent { | ||
| public: | ||
| SchedulingAgent(const gsl::not_null<core::controller::ControllerServiceProvider*> controller_service_provider, std::shared_ptr<core::Repository> repo, std::shared_ptr<core::Repository> flow_repo, | ||
| SchedulingAgent(const gsl::not_null<core::controller::ControllerServiceProvider*> controller_service_provider, std::shared_ptr<provenance::ProvenanceRepository> repo, std::shared_ptr<core::Repository> flow_repo, |
Member
There was a problem hiding this comment.
I believe the "repo" naming of identifiers that have to be provenance repo was a mistake. I'm glad the type makes it clearer now, but I'd change the parameter and member names too. provenance_repo or prov_repo seem like good options to me.
Comment on lines
+49
to
+51
| Identifier& operator++(); | ||
| Identifier operator++(int); | ||
|
|
Member
There was a problem hiding this comment.
why do we need these UUID increments? I believe the Identified class is not meant to represent integer auto-increment keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2195
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.