Restore the common wording on the download page - #421
Closed
slachiewicz wants to merge 1 commit into
Closed
Conversation
slachiewicz
force-pushed
the
modernize-download-page
branch
from
August 9, 2026 23:20
95b6bd8 to
2ae7890
Compare
slachiewicz
changed the title
slachiewicz
force-pushed
the
modernize-download-page
branch
from
August 9, 2026 23:28
2ae7890 to
5afaf24
Compare
The wording here had drifted from the text the rest of the Maven estate uses. This restores the shared form so the page is identical to its counterparts apart from the distribution area and the artifact name. Comparing the rendered HTML before and after shows the reworded version had dropped three links, leaving the text as plain prose: the verification instructions, the KEYS file and the archive site. Restoring the common wording restores all three. The ASF licence header is left exactly as it was. Generated-by: Claude Opus 5 (1M context)
slachiewicz
force-pushed
the
modernize-download-page
branch
from
August 10, 2026 00:07
5afaf24 to
5f539ab
Compare
elharo
requested changes
Aug 10, 2026
elharo
left a comment
elharo
left a comment
Contributor
There was a problem hiding this comment.
The change you're trying to revert was a deliberate improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wording on this page had drifted from the text the rest of the Maven estate uses. This restores the shared wording so the page is identical to its counterparts apart from the distribution area and the artifact name.
Format is unchanged — this stays xdoc.
This is not purely cosmetic
Diffing the rendered HTML before and after shows the reworded version had silently dropped three hyperlinks, leaving the text as plain prose:
https://www.apache.org/info/verification.html(how to verify a download)https://downloads.apache.org/maven/KEYS(the signing keys)https://archive.apache.org/dist/maven/…/(the archive site)Restoring the common wording restores all three.
Headings, generated anchors (
#Files,#Previous_Versions) and the table are unchanged, so no URL and no in-page anchor moves.Verified by local site build and HTML diff only — not claiming CI is green; draft until it is.
Licence header: left byte-for-byte as it was. My first pass spliced in a canonical header and silently downgraded an
https://LICENSE-2.0 URL tohttp://in a sibling repo; the generator now preserves each file's existing preamble and never rewrites it.Format: this stays xdoc. Converting the page to Markdown was evaluated separately and shown to round-trip losslessly, and was then deliberately declined — noting that here so the question does not get reopened from scratch later.