Remove the deprecated localRepository from MavenReportExecutorRequest - #159
Merged
Conversation
Deprecated by MSHARED-1207 and shipped that way since 2.0.0-M10; nothing in this project ever read the field, and maven-site-plugin, the only consumer in the Maven estate, never set it. The test keeps org.apache.maven.artifact.repository.ArtifactRepository: MavenExecutionRequest still takes one to build the MavenSession, and that does not change until the baseline is Maven 4.
slachiewicz
added
breaking
slachiewicz
marked this pull request as ready for review
August 16, 2026 11:19
michael-o
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MavenReportExecutorRequest#localRepositoryhas been deprecated since MSHARED-1207 (2.0.0-M10, March 2023). Nothing in this project reads it, and maven-site-plugin — the only consumer in the Maven estate — builds the request without it.Removing public API means the next release is 2.1.0 rather than 2.0.2. No version bump here; that is the release manager's call.
This does not clear
org.apache.maven.artifact.repository.ArtifactRepositoryfrom the project. The test still needs one becauseMavenExecutionRequesttakes it to build theMavenSession, and that only goes away with a Maven 4 baseline.Independent of #158 — this one is a straight deprecated-API removal and does not touch the Maven baseline.
Verified:
mvn verify→ 4 tests, 0 failures.This change was created with AI assistance.