Add null check for artifact parameter in evaluateFileNameMapping - #72
Open
elharo wants to merge 1 commit into
Open
Add null check for artifact parameter in evaluateFileNameMapping#72elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
evaluateFileNameMapping threw an opaque NullPointerException when artifact was null. Add an explicit null check that throws IllegalArgumentException with a clear message. Also added a test that verifies the expected exception is thrown. Closes #62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MappingUtils.evaluateFileNameMapping(String, Artifact)throws an opaqueNullPointerExceptionwhenartifactis null, making it difficult for callers to diagnose the issue:Fix
Added an explicit null check at the start of
evaluateFileNameMappingthat throwsIllegalArgumentExceptionwith a clear message:Test
Added
mappingWithNullArtifactwhich verifies thatIllegalArgumentExceptionis thrown when null is passed for the artifact parameter.All 7 tests pass.
Closes #62