Add tests for @{baseVersion}@ and DEFAULT_FILE_NAME_MAPPING constants - #71
Open
elharo wants to merge 1 commit into
Open
Add tests for @{baseVersion}@ and DEFAULT_FILE_NAME_MAPPING constants#71elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
Both DEFAULT_FILE_NAME_MAPPING and DEFAULT_FILE_NAME_MAPPING_CLASSIFIER
use @{baseVersion}@ but no test ever exercised this expression or these
constants. Add four tests:
- baseVersionMapping: directly tests @{baseVersion}@ in an expression
- defaultFileNameMapping: tests DEFAULT_FILE_NAME_MAPPING constant
- defaultFileNameMappingClassifier: tests DEFAULT_FILE_NAME_MAPPING_CLASSIFIER with a classifier
- defaultFileNameMappingNullClassifier: tests DEFAULT_FILE_NAME_MAPPING_CLASSIFIER without a classifier
Closes #64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
DEFAULT_FILE_NAME_MAPPINGandDEFAULT_FILE_NAME_MAPPING_CLASSIFIERuse@{baseVersion}@, but no existing test ever exercised this expression or these constants.Added four tests:
baseVersionMapping-- directly tests@{baseVersion}@in a mapping expressiondefaultFileNameMapping-- tests theDEFAULT_FILE_NAME_MAPPINGconstantdefaultFileNameMappingClassifier-- testsDEFAULT_FILE_NAME_MAPPING_CLASSIFIERwith a non-null classifierdefaultFileNameMappingNullClassifier-- testsDEFAULT_FILE_NAME_MAPPING_CLASSIFIERwith a null classifierAll 10 tests pass.
Closes #64