Simplify regex in MappingUtils.evaluateFileNameMapping - #68
Open
elharo wants to merge 1 commit into
Open
Conversation
Remove the unnecessary empty capture group and __artifact prefix
trick from the RegexBasedInterpolator pattern.
The previous regex used startRegex='\@\{(' and
endRegex=')?([^}]+)\}@' with thisPrefixPattern='__artifact',
creating a complex pattern with an unused optional group
wrapping the dummy __artifact string.
The new approach uses an empty startRegex with the full
pattern '\@\{([^}]+)\}@' in endRegex and passes null
for thisPrefixPattern, achieving the same result more
directly.
Closes #67
elharo
marked this pull request as draft
August 19, 2026 19:10
elharo
marked this pull request as ready for review
August 19, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unnecessary empty capture group and
__artifactprefix trick from theRegexBasedInterpolatorpattern inMappingUtils.evaluateFileNameMapping.Problem
The previous regex used
startRegex='\\@\\{('andendRegex=')?([^}]+)\\}@'withthisPrefixPattern='__artifact', creating the pattern:This contained an unused optional group
(__artifact)?that served no real purpose -- the__artifactstring was a dummy prefix intended to be filtered out by the optional group, but since the custom prefix/suffix already delimit@{...}@expressions, the prefix filtering is redundant.Fix
The new approach uses an empty
startRegexwith the full capture pattern inendRegexand passesnullforthisPrefixPattern:This produces the simpler pattern
\@\{([^}]+)\}@with the key captured directly in group 1.Verification
All existing tests pass without modification:
completeMappingnoVersionMappingmappingWithGroupIdmappingWithClassifiermappingWithNullClassifiermappingWithOptionalClassifier(MWAR-212)Closes #67