Fix setEscapeString(null) to clear escape state - #373
Open
elharo wants to merge 1 commit into
Open
Conversation
setEscapeString(null) and setEscapeString("") were silently ignored,
leaving the previous escape string and useEscape flag intact. A caller
who sets escape string to non-null, then later sets it to null to
disable escaping, would find escaping still active with the old string.
Fix by clearing escapeString to null and useEscape to false when the
input is null or empty, and always call calculateMarkLength().
Also added tests verifying both null and empty string disable escaping.
Closes #351
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
setEscapeString(null)andsetEscapeString("")were silently ignored inAbstractFilterReaderLineEnding. When called after a previous non-null value, the old escape string anduseEscapeflag were retained, so escaping remained active.Fix
Changed
setEscapeStringto explicitly clearescapeStringtonullanduseEscapetofalsewhen the input is null or empty, and movedcalculateMarkLength()outside the conditional so it's always called.Tests
Added two tests that verify both
nulland empty string properly disable escaping:setEscapeStringNullShouldDisableEscaping-- sets escape to\\, thennull, assertsgetEscapeString()returns nullsetEscapeStringEmptyShouldDisableEscaping-- sets escape to\\, then"", assertsgetEscapeString()returns nullBoth tests fail before the fix (
expected: <null> but was: <\>) and pass after. All 75 tests pass.Closes #351