Skip to content

fix(agent-guard): make the fresh-clone hook guard cross-platform (Windows) #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 12, 2026
Merged

fix(agent-guard): make the fresh-clone hook guard cross-platform (Windows) #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions skills/setup/adopt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,16 +1292,17 @@ Four passes, in this order:

```json
{ "matcher": "Bash", "hooks": [ { "type": "command",
"command": "[ -f \"$CLAUDE_PROJECT_DIR/.claude/hooks/agent-guard.py\" ] && python3 \"$CLAUDE_PROJECT_DIR/.claude/hooks/agent-guard.py\" || true",
"command": "python3 -c \"import os,sys,subprocess; p=os.path.join(os.environ.get('CLAUDE_PROJECT_DIR',''),'.claude','hooks','agent-guard.py'); sys.exit(subprocess.call([sys.executable,p]) if os.path.isfile(p) else 0)\"",
"timeout": 30 } ] }
```

The `[ -f … ] && … || true` guard makes the hook a **no-op on a
fresh clone** — before `/magpie-setup` has synced `agent-guard.py`
in (the script is gitignored framework code, not committed), so
without the guard the committed hook would exec a missing file on
every Bash call and a `PreToolUse` error can block the tool. Once
the script is present the guard passes and the hook runs normally.
The command no-ops when `agent-guard.py` is absent (a **fresh
clone**, before `/magpie-setup` has synced the gitignored script in)
and runs the guard otherwise — so the committed hook never execs a
missing file on a Bash call (a `PreToolUse` error can block the
tool). It is written as an inline `python3 -c` existence check
rather than a shell one-liner (`[ -f … ] && … || true`) so it works
on **Windows** (PowerShell) too, not only POSIX shells.

Wiring happens **only once**; thereafter guards are
added/removed purely by syncing `guards.d` — no settings.json
Expand Down
2 changes: 1 addition & 1 deletion tools/agent-guard/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ The guard is registered as a `PreToolUse` hook on the `Bash` matcher in
{
"matcher": "Bash",
"hooks": [
{ "type": "command", "command": "[ -f \"$CLAUDE_PROJECT_DIR/.claude/hooks/agent-guard.py\" ] && python3 \"$CLAUDE_PROJECT_DIR/.claude/hooks/agent-guard.py\" || true", "timeout": 30 }
{ "type": "command", "command": "python3 -c \"import os,sys,subprocess; p=os.path.join(os.environ.get('CLAUDE_PROJECT_DIR',''),'.claude','hooks','agent-guard.py'); sys.exit(subprocess.call([sys.executable,p]) if os.path.isfile(p) else 0)\"", "timeout": 30 }
]
}
]
Expand Down