infra(.asf.yaml): require one approving review on main#818
Draft
potiuk wants to merge 1 commit into
Draft
Conversation
Member
Author
|
Drafted it to not merge it too early |
Now that Apache Magpie is an established Top-Level Project with its own
PMC, add branch protection requiring at least one approving review from
a committer before any PR merges into `main`, replacing the bootstrap
posture where a maintainer could self-merge after CI green.
required_pull_request_reviews:
required_approving_review_count: 1
dismiss_stale_reviews: true
dismiss_stale_reviews ensures the approving reviewer signs off on the
final state of the diff after any further pushes. require_code_owner_reviews
is left off — there is no CODEOWNERS file, so any committer's approval
satisfies the requirement.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
potiuk
force-pushed
the
infra/require-review-on-main
branch
from
d7409e8 to
23e35e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Apache Magpie is an established Top-Level Project with its own PMC, this adds branch protection requiring at least one approving review from a committer before any PR merges into
main, replacing the bootstrap posture where a maintainer could self-merge after CI green.Change
dismiss_stale_reviews: true— a new push after approval dismisses the stale approval, so the approving reviewer signs off on the final state of the diff.require_code_owner_reviewsis left off — there is no CODEOWNERS file, so any committer's approval satisfies the requirement.Notes
.asf.yamlcomment lines, so whichever merges second will need a trivial rebase.protected_brancheswithin a few minutes of merge tomain.🤖 Generated with Claude Code