Document the build lifecycle and troubleshooting#488
Conversation
Add two Antora pages describing what the Logging Parent POM adds to the Maven build: - `build-lifecycle.adoc`: the checks, generated artifacts, and POM transformations bound to `./mvnw verify`; the opt-in profiles (build modifiers and commands); and what is inherited from the ASF Parent POM. - `troubleshooting.adoc`: recipes for the two checks that are hardest to diagnose, the BND baseline API-compatibility check and the `requireUpperBoundDeps` dependency-convergence check, using real captured error output. Wire both pages into the site navigation under a new "Build" group. Assisted-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
I just have a few minor suggestions and questions for you to consider:
|
ramanathan1504
left a comment
There was a problem hiding this comment.
@ppkarwasz Changelog is missing right?
* Link to the Git documentation on .gitattributes and give an example that includes the mvnw.cmd CRLF exception. * Clarify that the release profile requires both the project version and every dependency to be non-SNAPSHOT. * Replace concrete version numbers in the troubleshooting recipes with x.y.z and a.b.c placeholders, explained in a note. * Point the changelog step of the MINOR recipe at the pending src/changelog/.<major>.x.x/ directory. * Fix bold/italic markup consistency (*not*). Assisted-By: Claude Fable 5 <noreply@anthropic.com>
|
Hi @ramanathan1504, I addressed your remarks in 365865b
I don't think this kind of change needs a changelog: it does not touch the Maven artifact itself, only it documentation. |
LGTM |
* Document the build lifecycle and troubleshooting Add two Antora pages describing what the Logging Parent POM adds to the Maven build: - `build-lifecycle.adoc`: the checks, generated artifacts, and POM transformations bound to `./mvnw verify`; the opt-in profiles (build modifiers and commands); and what is inherited from the ASF Parent POM. - `troubleshooting.adoc`: recipes for the two checks that are hardest to diagnose, the BND baseline API-compatibility check and the `requireUpperBoundDeps` dependency-convergence check, using real captured error output. Wire both pages into the site navigation under a new "Build" group. Assisted-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Address review remarks * Link to the Git documentation on .gitattributes and give an example that includes the mvnw.cmd CRLF exception. * Clarify that the release profile requires both the project version and every dependency to be non-SNAPSHOT. * Replace concrete version numbers in the troubleshooting recipes with x.y.z and a.b.c placeholders, explained in a note. * Point the changelog step of the MINOR recipe at the pending src/changelog/.<major>.x.x/ directory. * Fix bold/italic markup consistency (*not*). Assisted-By: Claude Fable 5 <noreply@anthropic.com>
Summary
Adds two Antora documentation pages that explain what the Logging Parent POM adds to a Maven build, addressing the long-standing gap that
features.adoconly lists bundled plugins.build-lifecycle.adoc: a phase-by-phase overview table plus sections on:META-INF/{LICENSE,NOTICE,DEPENDENCIES});${revision}resolution and BOM flattening);release,coverage,apache.snapshots) and commands (changelog-release,distribution,deploy).troubleshooting.adoc: debugging recipes for the two checks that are hardest to diagnose:MICRO/MINOR/MAJORfixes, and the rationale behind the package-versioning convention);requireUpperBoundDepsorder-independent dependency resolution check (how to read the error and whether to pin, bump, or unpin).Both troubleshooting recipes use real error output captured by reproducing the failures locally.
Both pages are wired into the site navigation under a new "Build" group.
Notes
site-lifecyclepage is intentionally deferred for a follow-up; its references were removed from this change.🤖 Generated with Claude Code