fix: correct NOT STARTS WITH projection for truncated partitions#3528
Open
GayathriSrividya wants to merge 1 commit into
Open
fix: correct NOT STARTS WITH projection for truncated partitions#3528GayathriSrividya wants to merge 1 commit into
GayathriSrividya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3493
Summary
Fixes incorrect projection of
NOT STARTS WITHpredicates for truncated string/binary partition fields. The current implementation unsafely truncates the filter literal without checking its length relative to the truncate width.Root Cause
The
TruncateTransform.projectmethod calls_truncate_arraywhich blindly truncates the literal for bothSTARTS WITHandNOT STARTS WITHpredicates:For
NOT STARTS WITH "hello"withtruncate[2], this produces:NOT STARTS WITH "he"Solution
Add special handling for
BoundNotStartsWithin theprojectmethod following the Java/Go reference behavior:NOT STARTS WITHliteral (safe)!=instead (safe equality check)None(no inclusive projection possible)pyiceberg/transforms.py
NOT STARTS WITHhandling before calling_truncate_arraytests/test_transforms.py
test_projection_truncate_string_not_starts_withto expectNone(prefix_length > width is unsafe)test_projection_truncate_string_not_starts_with_shorter_literal(prefix_length == width →!=)test_projection_truncate_string_not_starts_with_original_literal(prefix_length < width → original)Validation
make lint✓ (all pre-commit hooks pass)pytest tests/test_transforms.py→ 280 passed ✓