[Bug Fix] all TimeTransforms for falsey values - #280
Merged
Conversation
Fokko
approved these changes
Jan 18, 2024
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Ah, this also got me more than once 😄
Collaborator
Author
|
CI failure related to: #279 |
Contributor
|
@syun64 Thanks, let me poke someone to get it in 👍 |
Collaborator
Author
|
No problem, and thank you! :) |
Contributor
|
@syun64 The other PR is in 👍 Can you rebase? |
Collaborator
Author
|
of course! |
HonahX
approved these changes
Jan 18, 2024
HonahX
left a comment
HonahX
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the quick fix.
Collaborator
Author
Contributor
|
@syun64 Sorry I was interrupted by other things. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on @HonahX 's comment on #276