fix(table): resolve write planning snapshots from the target branch head (#1638) - #1839
Open
badalprasadsingh wants to merge 1 commit into
Open
fix(table): resolve write planning snapshots from the target branch head (#1638)#1839badalprasadsingh wants to merge 1 commit into
badalprasadsingh wants to merge 1 commit into
Conversation
Signed-off-by: badalprasadsingh <badal@datazip.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1638 and a follow-up to #1637.
Branch writes parented on the branch but planned against main. Now,
planningSnapshotresolves delete, replace, duplicate-check and deletion-vector look ups from the target branch.Dropped the
requireMainBranchguard added in #1637. Retry build fixed for peers advancing other branches.Testing
Added 13 branch-planning tests + retry coverage.