Skip to content

fix(hive): reject metastore URIs without a host - #1720

Open
fallintoplace wants to merge 3 commits into
apache:mainfrom
fallintoplace:fix/hive-metastore-host
Open

fix(hive): reject metastore URIs without a host#1720
fallintoplace wants to merge 3 commits into
apache:mainfrom
fallintoplace:fix/hive-metastore-host

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Require a hostname before creating a Hive metastore client.
  • Reject authority-less URIs and URIs with an empty host.
  • Keep the default port at 9083 when the URI has no port.

Why

url.Parse accepts values such as thrift://:9083 and localhost:9083 without providing a host for the metastore connection. These values now fail before the client is created.

Tests

  • go test ./catalog/hive -count=1
  • go test ./... -count=1

@fallintoplace
fallintoplace marked this pull request as ready for review August 14, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant