Skip to content

feat(rest): implement create table - #417

Merged
wgtmac merged 5 commits into
apache:mainfrom
HeartLinked:feat/rest-createtable
Dec 19, 2025
Merged

feat(rest): implement create table#417
wgtmac merged 5 commits into
apache:mainfrom
HeartLinked:feat/rest-createtable

Conversation

@HeartLinked

@HeartLinked HeartLinked commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

closes #389 .

Comment thread src/iceberg/catalog.h Outdated
Comment thread src/iceberg/catalog/rest/json_internal.cc Outdated
Comment thread src/iceberg/catalog/rest/json_internal.cc Outdated
Comment thread src/iceberg/catalog/rest/rest_catalog.cc Outdated
Comment thread src/iceberg/catalog/rest/rest_catalog.cc Outdated
Comment thread src/iceberg/catalog/rest/rest_catalog.cc Outdated
Comment thread src/iceberg/catalog/rest/rest_catalog.h Outdated
Comment thread src/iceberg/test/rest_catalog_test.cc Outdated
Comment thread src/iceberg/test/rest_catalog_test.cc Outdated
Comment thread src/iceberg/test/rest_catalog_test.cc Outdated
@HeartLinked
HeartLinked force-pushed the feat/rest-createtable branch from a2fa579 to c16b422 Compare December 19, 2025 07:43
Comment thread src/iceberg/catalog/rest/rest_catalog.cc
Comment thread src/iceberg/test/rest_catalog_test.cc Outdated
{"community", "apache"}};

// Create parent namespaces first
auto status = catalog->CreateNamespace(Namespace{.levels = {"test_create_table"}}, {});

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required by this PR: we can add some common functions to quickly create the catalog and namespace since these are reused in different cases.

Comment thread src/iceberg/catalog/rest/json_internal.cc
Comment thread src/iceberg/catalog/rest/json_internal.cc Outdated
Comment thread src/iceberg/catalog/rest/json_internal.cc Outdated
Comment thread src/iceberg/catalog/rest/rest_catalog.cc Outdated

@wgtmac wgtmac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wgtmac
wgtmac merged commit 1a56283 into apache:main Dec 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement CreateTable for REST catalog

2 participants