feat: add manifest evaluator - #403
Merged
Merged
Conversation
dongxiao1198
force-pushed
the
manifest_evaluator
branch
from
December 8, 2025 06:55
e094d0f to
67810d7
Compare
HuaHuaY
reviewed
Dec 8, 2025
| explicit ManifestEvalVisitor(const ManifestFile& manifest) | ||
| : stats_(manifest.partitions) {} | ||
|
|
||
| Result<bool> AlwaysTrue() override { return true; } |
Contributor
There was a problem hiding this comment.
@wgtmac Too many subclasses override these methods but it seems meaningless. Should we open another PR to merge the implementations?
dongxiao1198
force-pushed
the
manifest_evaluator
branch
from
December 8, 2025 09:34
67810d7 to
aad8b49
Compare
HuaHuaY
reviewed
Dec 8, 2025
HuaHuaY
approved these changes
Dec 8, 2025
wgtmac
reviewed
Dec 10, 2025
wgtmac
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support manifest evaluator and unittest