feat: implement InMemoryCatalog's UpdateTable - #386
Merged
Conversation
WZhuo
force-pushed
the
memory_catalog
branch
4 times, most recently
from
December 5, 2025 07:41
55d3900 to
67a5362
Compare
zhjwpku
reviewed
Dec 5, 2025
HuaHuaY
reviewed
Dec 5, 2025
WZhuo
force-pushed
the
memory_catalog
branch
3 times, most recently
from
December 9, 2025 12:07
b606110 to
94ff1e5
Compare
Member
|
This PR seems have carried other unrelated changes. Could you fix it? |
WZhuo
force-pushed
the
memory_catalog
branch
from
December 12, 2025 03:27
94ff1e5 to
7105a2d
Compare
wgtmac
reviewed
Dec 12, 2025
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
My main concern of this change is the addition of metadata_file_location to TableMetadata which makes it not a pure data-carrying object for table metadata json. Can we address this?
WZhuo
force-pushed
the
memory_catalog
branch
3 times, most recently
from
December 15, 2025 12:36
194d4c9 to
8460b44
Compare
WZhuo
force-pushed
the
memory_catalog
branch
from
December 15, 2025 12:39
8460b44 to
53bb3ae
Compare
wgtmac
approved these changes
Dec 16, 2025
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for working on this!
wgtmac
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.