chore: remove pending_update_test - #379
Merged
Merged
Conversation
WZhuo
force-pushed
the
fix_pending_update_test
branch
from
December 1, 2025 09:30
e29fde1 to
b709243
Compare
WZhuo
force-pushed
the
fix_pending_update_test
branch
from
December 1, 2025 09:50
b709243 to
df119ed
Compare
WZhuo
changed the title
wgtmac
approved these changes
Dec 1, 2025
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
+1
I agree that it does not make sense to add test for a pure virtual class.
HeartLinked
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378