feat: add update table properties support - #363
Merged
Conversation
WZhuo
force-pushed
the
update_properties
branch
23 times, most recently
from
December 2, 2025 03:04
5f98124 to
387401a
Compare
wgtmac
reviewed
Dec 2, 2025
HeartLinked
reviewed
Dec 2, 2025
WZhuo
force-pushed
the
update_properties
branch
5 times, most recently
from
December 2, 2025 12:28
11604e3 to
ce0b6ea
Compare
WZhuo
force-pushed
the
update_properties
branch
from
December 3, 2025 02:02
ce0b6ea to
d50ffd6
Compare
wgtmac
reviewed
Dec 3, 2025
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
This looks good now. I just left some minor comments.
| "counts"; | ||
|
|
||
| auto result = MetricsConfig::VerifyReferencedColumns(updates, *schema_); | ||
| EXPECT_FALSE(result.has_value()) |
Member
There was a problem hiding this comment.
nit: you can #include "iceberg/test/matchers.h" and then write
EXPECT_THAT(result, IsError(ErrorKind::kValidationFailed));
EXPECT_THAT(result, HasErrorMessage("..."));
Contributor
Author
There was a problem hiding this comment.
Replace all EXPECT_xxx(result.has_value()) with EXPECT_THAT(result, IsError/IsOk);
Comment on lines
+43
to
+44
| UpdateProperties(TableIdentifier identifier, std::shared_ptr<Catalog> catalog, | ||
| std::shared_ptr<TableMetadata> metadata); |
Member
There was a problem hiding this comment.
Sounds good. I still suggest renaming metadata to base to make it explicit.
Do we need to check if catalog or base is null? We cannot throw in the ctor, perhaps we should check them in Apply and Commit.
| /// | ||
| /// \param format The file format type to use as default | ||
| /// \return Reference to this UpdateProperties for chaining | ||
| UpdateProperties& DefaultFormat(FileFormatType format); |
Member
There was a problem hiding this comment.
Yes I understand. I still think we don't need special case the file format config to make the API simple. The Java impl seems have some historical reasons and we don't need to follow everything.
WZhuo
force-pushed
the
update_properties
branch
from
December 3, 2025 03:30
d50ffd6 to
2b308fb
Compare
WZhuo
force-pushed
the
update_properties
branch
from
December 3, 2025 03:37
2b308fb to
04505a4
Compare
wgtmac
reviewed
Dec 3, 2025
wgtmac
approved these changes
Dec 3, 2025
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this! LGTM
wgtmac
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.