[ISSUE-789] Add TRIM, LPAD, and RPAD string functions - #826
Open
914zzzz wants to merge 1 commit into
Open
Conversation
Author
Member
|
Please check and fix the CI status before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #789 by adding and registering TRIM, LPAD, and RPAD as built-in SQL functions. Supports String and BinaryString overloads, null arguments, Unicode code-point lengths, truncation, zero or negative target lengths, and empty pad strings. TRIM removes ASCII spaces while preserving tabs. Adds unit tests and SQL integration resources for Unicode, null, empty pad, and boundary cases. Plan-module verification passed: 6 tests, 0 failures, with jacoco skipped because the repository JaCoCo version does not support Java 21. Runtime SQL tests compile but the local Windows/Java 21 environment fails during QueryTester BRPC shutdown; upstream CI should execute them. An earlier implementation for #789 is open as #811; this PR is a corrected alternative incorporating its review findings.