-
Notifications
You must be signed in to change notification settings - Fork 431
feat(compiler): Add grpc support for Swift #3776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yash-agarwa-l
wants to merge
32
commits into
apache:main
Choose a base branch
from
yash-agarwa-l:grpc-swift
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6ee6c4c
feat(compiler): add Swift gRPC service generation
yash-agarwa-l 9d15a1b
feat(compiler): preflight Swift gRPC collisions
yash-agarwa-l e78e79e
test(compiler): cover Swift gRPC codegen
yash-agarwa-l b554dae
test(compiler): build and run the Swift gRPC fixture
yash-agarwa-l e865db5
test(grpc): generate Swift companions in the interop harness
yash-agarwa-l efdcad2
docs: document Swift gRPC support
yash-agarwa-l 034861b
style(compiler): wrap long Swift gRPC handler closures
yash-agarwa-l 7f3d888
style(compiler): make Swift gRPC companions swiftlint-clean
yash-agarwa-l 1ab4cf8
test(compiler): document the Swift common-root package limit
yash-agarwa-l f746c2c
fix(compiler): use a per-thread Fory in Swift gRPC marshaller
yash-agarwa-l 00f2657
docs: note Swift gRPC client and interceptor limits
yash-agarwa-l 3c93b3e
test(compiler): prove Swift marshaller thread-safety under TSan
yash-agarwa-l dd40171
test(compiler): gate the Swift TSan test behind FORY_SWIFT_TSAN
yash-agarwa-l 4922f77
feat(compiler): reserve inherited member names in Swift gRPC
yash-agarwa-l 9cf3cee
Merge remote-tracking branch 'upstream/main' into grpc-swift
yash-agarwa-l 4b5278e
refactor(grpc): move Swift toolchain tests into integration_tests
yash-agarwa-l 6d44772
fix(compiler): make the Swift gRPC wire wrapper Sendable
yash-agarwa-l 5c5c15c
test(grpc): run Swift toolchain gRPC tests in their package
yash-agarwa-l 602183a
Merge remote-tracking branch 'upstream/main' into grpc-swift
yash-agarwa-l e21a9a4
chore(compiler): fix ruff lint in swift gRPC codegen
yash-agarwa-l de06611
fix(java): balance read ref id stack for NOT_NULL values
yash-agarwa-l f294ef3
Merge remote-tracking branch 'upstream/main' into grpc-swift
yash-agarwa-l 3c50b8c
Merge remote-tracking branch 'upstream/main' into grpc-swift
yash-agarwa-l 20047dc
Revert "fix(java): balance read ref id stack for NOT_NULL values"
yash-agarwa-l df15e7c
fix(swift): reserve a ref slot for tracked value roots
yash-agarwa-l f7ea499
Merge remote-tracking branch 'upstream/main' into grpc-swift
yash-agarwa-l 574542c
fix(compiler): constrain Swift gRPC generics to self-provided seriali…
yash-agarwa-l 84adfc4
docs(swift): align gRPC page front
yash-agarwa-l d97696a
docs(compiler): document Swift gRPC service companions
yash-agarwa-l 9efe651
test(grpc): add Java<->Swift gRPC interop harness
yash-agarwa-l 044dddc
ci: run Java/Swift gRPC interop tests
yash-agarwa-l 36288fc
fix(compiler): require Sendable payloads in Swift gRPC companions
yash-agarwa-l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run the concurrency regression under ThreadSanitizer
This runs only plain
swift test. The sole--sanitize=threadcommand is behindFORY_SWIFT_TSAN=1in another script that this workflow never invokes, so the test and PR description's TSan safety claim is not exercised by CI. Please add a sanitized invocation, preferably filtered to the marshaller concurrency test.