perf: Skip download of upgraded segments on historicals#19676
Draft
kfaraz wants to merge 1 commit into
Draft
Conversation
kfaraz
commented
Jul 10, 2026
| } | ||
| if (needsLoad) { | ||
| loadInLocationWithStartMarker(dataSegment, storageDir); | ||
| final File baseDir = findCachedBaseSegmentDir(mountLocation); |
Contributor
Author
There was a problem hiding this comment.
This doesn't seem correct, the base segment could be in some other location too.
kfaraz
commented
Jul 10, 2026
| * {@link #loadInLocationWithStartMarker}. | ||
| */ | ||
| @GuardedBy("entryLock") | ||
| private void copyFromBaseSegmentDir(final File baseDir, final File destDir) |
Contributor
Author
There was a problem hiding this comment.
This method needs to hold the entryLock for the base segment too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
upgradedFromSegmentIdtoDataSegmentDataSegmentPlusbut the object sent over the wire to historicals in a load request is a plainDataSegment(or actually aLoadableDataSegment)SegmentLocalCacheManagerto copy files from base directory to actual directoryPending items
upgradedFromSegmentIdcolumn (it might already be happening, atleast in the incremental cache)This PR has: