fix: constant columns for clustered segment#19675
Open
clintropolis wants to merge 3 commits into
Open
Conversation
changes: * `QueryableIndex#getClusterGroupQueryableIndex` now accepts a boolean flag to control whether or not constant columns are created for the clustering columns (true for queries, false for persist/merge) * these constants resolve some issues around filtering clustered segments
capistrant
approved these changes
Jul 10, 2026
capistrant
left a comment
capistrant
left a comment
Contributor
There was a problem hiding this comment.
One observation regarding defensiveness for you to consider
| "clustering column [%s] is missing a type", | ||
| columnName | ||
| )); | ||
| final BaseColumnHolder holder = makeConstantColumnHolder(columnType, clusteringValues[i], numRows, bitmapFactory); |
Contributor
There was a problem hiding this comment.
putting trust in caller to pass a good clusteringValues array. bad callsite use could index oob. perhaps worth a defensive size comparison with clusteringColumns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changes:
QueryableIndex#getClusterGroupQueryableIndexnow accepts a boolean flag to control whether or not constant columns are created for the clustering columns (true for queries, false for persist/merge)