fix: repair broken rust-test build on main (init_datasource_exec arg mismatch)#4712
Merged
Merged
Conversation
…ec test The unit test added in apache#4707 calls init_datasource_exec with 16 arguments, but apache#4357 had already added a 17th parameter (allow_timestamp_ltz_to_ntz) to the signature. The two PRs did not conflict textually, so the mismatch was a semantic merge conflict that only surfaces when compiling test code: the non-test build passes while cargo test fails with E0061, breaking the rust-test CI job on main. Insert the missing allow_timestamp_ltz_to_ntz argument (false) before session_ctx so the test call matches the current signature.
comphead
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The
rust-testCI job is currently failing onmainwith a compile error:This is a semantic merge conflict between two PRs that did not conflict textually:
allow_timestamp_ltz_to_ntz, toinit_datasource_exec.init_datasource_execwith only 16 arguments.#4707 was based on
mainbefore #4357 merged, so its test matched the 16-parameter signature and compiled on the branch. Once both landed onmain, the test call no longer matched the signature. The non-test build does not compile that test code, soBuild Native Librarypasses whilecargo test(therust-testjob) fails. This blocks every open PR.What changes are included in this PR?
Insert the missing
allow_timestamp_ltz_to_ntzargument (false) immediately beforesession_ctxin the test call site, matching the current signature and the existing production call site inplanner.rs.How are these changes tested?
cargo test -p datafusion-comet --no-runnow compiles successfully (it failed with E0061 before this change). The existingrust-testCI job exercises this test.