Implemented Data Editor Message Registry#1716
Conversation
f94da23 to
f2d91e0
Compare
|
Looks like I'll have to fix tests due to the strict type checks when transpiling with |
13cb602 to
a72d6ca
Compare
|
Disregard, I fixed this issue. |
c99639a to
9c28091
Compare
|
Some changes needed to be made in order to get the updated data editor files to function properly for CI. Everything should be good to go, now. |
|
@stricklandrbls Is this PR ready to test? |
e5101a8 to
a8dd573
Compare
|
The svelte imports should now all be aliased if the path is not a sub-directory of its path. The rest of the extension imports still need to be updated. |
|
@stricklandrbls , I did some testing on this code and found that the data editor does not open automatically when starting debug. Wondering if some messages are missing? The status bar at the bottom shows no indication that it is even trying to connect to the server. |
Awesome thanks for testing this. I'll take a look |
a8dd573 to
c648f68
Compare
|
@lrbarber The latest commit should fix the issue of the Data Editor not opening for the target data file in a debug session. |
c648f68 to
886c848
Compare
886c848 to
8f16bfa
Compare
lrbarber
left a comment
There was a problem hiding this comment.
See comment above about closing then reopening a second file
Awesome thanks for the thorough testing. I'll work on a fix for this |
8f16bfa to
ab0cb40
Compare
|
@lrbarber @hdalsania @scholarsmate - Sorry for the delay in getting updates out for this PR. I have been out of town a lot recently. I believe that the error is fixed for sessions opened for a file that should be disposed. |
|
@lrbarber thanks for testing this out. I'll take a look here in a bit |
a8b62cb to
495f715
Compare
|
@lrbarber - I pushed up a commit which I think completely resolves this error. I did in fact see what you were seeing and with the latest commit it seems to be resolved. |
|
@stricklandrbls Something strange with the profiler. Scrolling down reveals inconsistency in field size: Also, all the numbers here are in hex, except when you hover over a bar in the bar chart, then the value at that location is shown in decimal.... |
|
@stricklandrbls After closing a data editor window (without closing the second VSCode wndow), the following messages begin scrolling in the Debug Console of the 'main' VSCode window: rejected promise not handled within 1 second: Error: Webview is disposed |
a738e52 to
bc36ee7
Compare
bc36ee7 to
0e038b7
Compare
|
@lrbarber - I believe these issues should be resolved with the latest commit |









Closes #1739
Closes #1659
Closes #1469
Closes #1058
Closes #669
Description
Wiki
Review Instructions including Screenshots
Developer Perspective Reviews
this.panel.postMessage(...).Screenshots ( dataEditorClient.ts -> 'fileInfo')
addListener(...).Screenshots ( DataEditorLineFeed.svelte -> 'viewportRefresh')
vscode.postMessage(...).Screenshots ( App.svelte -> 'requestEditedData')
Functionality Review
Verify that all message traffic behaves as expected. Message content can be identified within the ./src/ext_types/message.ts & ./src/ext_types/messageContent.ts