reject new line characters in obj writer object and group names#295
Open
digi-scrypt wants to merge 1 commit into
Open
reject new line characters in obj writer object and group names#295digi-scrypt wants to merge 1 commit into
digi-scrypt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeObjectName and writeGroupName write the name straight onto the o/g line, so a name with a \r or \n breaks out of that line and the rest is read back as separate OBJ statements (injected vertices/faces, or an mtllib pulling in an arbitrary material file). TextStlWriter.startSolid already guards its solid name against new lines; this adds the same check to the two ObjWriter name methods so the writer can't emit a name that re-parses as geometry. What happens if the name comes from user-supplied metadata is the case I had in mind here.