Reject truncated percent-encoding in RFC2231Utils.decodeText#475
Merged
Conversation
Member
|
Thank you @alhudz , merged 🚀 Please port to the |
Contributor
Author
|
Thanks for merging. Port to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: parse a
Content-Dispositionvalue ofform-data; name="f"; filename*=UTF-8''report%3(a truncated RFC 5987 percent escape) and read the resulting file name.Expected: rejected, the same as
%GGor a non-ASCII byte already are.Actual:
RFC2231Utils.decodeTextreturnsreport;fromHextreats a%with fewer than two following characters as end-of-input and returns what it decoded so far, dropping the truncated escape.Fix: throw
IllegalArgumentExceptionon a truncated%escape, so the value is rejected like every other malformed input infromHexand like the siblingQuotedPrintableDecoder. Covered by a new case inRFC2231UtilityTestCase.