Skip to content

Fix CollectionUtils collate keeping duplicate nulls when includeDuplicates is false#715

Merged
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:collate-null-dedup
Jul 18, 2026
Merged

Fix CollectionUtils collate keeping duplicate nulls when includeDuplicates is false#715
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:collate-null-dedup

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

collate used lastItem == null as its first-iteration sentinel, so a real null element (legal when a null-tolerant Comparator like Comparator.nullsFirst is supplied) was treated as unseen and re-added, leaving duplicate nulls in the result when includeDuplicates is false; found while tracing the merge dedup path with null-permitting comparators.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory garydgregory changed the title fix collate keeping duplicate nulls when includeDuplicates is false Fix collate keeping duplicate nulls when includeDuplicates is false Jul 18, 2026
@garydgregory garydgregory changed the title Fix collate keeping duplicate nulls when includeDuplicates is false Fix CollectionUtils collate keeping duplicate nulls when includeDuplicates is false Jul 18, 2026
@garydgregory
garydgregory merged commit 5b7ca64 into apache:master Jul 18, 2026
10 checks passed
@garydgregory

Copy link
Copy Markdown
Member

Good one @rootvector2 , merged 🚀

garydgregory added a commit that referenced this pull request Jul 18, 2026
not remove duplicate null elements when includeDuplicates is false
(#715).
@garydgregory

Copy link
Copy Markdown
Member

In the future, don't edit changes.xml.

@rootvector2

Copy link
Copy Markdown
Contributor Author

thanks for merging, and noted on changes.xml, I'll leave it out of future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants