Skip to content

CAMEL-24402: Lazy init threadNamePattern #25532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graben wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Open

CAMEL-24402: Lazy init threadNamePattern #25532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...el-base-engine/src/main/java/org/apache/camel/impl/engine/BaseExecutorServiceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ public void setDefaultThreadPoolProfile(ThreadPoolProfile defaultThreadPoolProfi

@Override
public String getThreadNamePattern() {
if (threadNamePattern == null) {
// set default name pattern which includes the camel context name
threadNamePattern = "Camel (" + camelContext.getName() + ") thread ##counter# - #name#";
}
return threadNamePattern;
}

Expand All @@ -162,7 +166,7 @@ public void setShutdownAwaitTermination(long shutdownAwaitTermination) {

@Override
public String resolveThreadName(String name) {
return ThreadHelper.resolveThreadName(threadNamePattern, name);
return ThreadHelper.resolveThreadName(getThreadNamePattern(), name);
}

@Override
Expand Down Expand Up @@ -443,11 +447,6 @@ protected void onNewExecutorService(ExecutorService executorService) {
protected void doInit() throws Exception {
super.doInit();

if (threadNamePattern == null) {
// set default name pattern which includes the camel context name
threadNamePattern = "Camel (" + camelContext.getName() + ") thread ##counter# - #name#";
}

// discover thread pool factory
if (threadPoolFactory == null) {
threadPoolFactory = ResolverHelper.resolveService(
Expand Down Expand Up @@ -611,7 +610,7 @@ private void onThreadPoolCreated(ExecutorService executorService, Object source,
}

protected ThreadFactory createThreadFactory(Object source, String name, boolean daemon) {
ThreadFactory factory = new CamelThreadFactory(threadNamePattern, name, daemon);
ThreadFactory factory = new CamelThreadFactory(getThreadNamePattern(), name, daemon);
for (ThreadFactoryListener listener : threadFactoryListeners) {
factory = listener.onNewThreadFactory(source, factory);
}
Expand Down