[AURON #2732] support platform option in Docker build mode#2371
[AURON #2732] support platform option in Docker build mode#2371zhaohehuhu wants to merge 1 commit into
Conversation
zhaohehuhu
changed the title
zhaohehuhu
changed the title
Do you mean building an |
There was a problem hiding this comment.
Pull request overview
Adds support for selecting a Docker target platform when building Auron in Docker mode, which is especially useful on ARM hosts that need to build linux/amd64 artifacts.
Changes:
- Adds a
--platformoption toauron-build.shand exports it viaAURON_DOCKER_PLATFORM. - Wires the exported platform into the Docker Compose service via the
platform:field.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dev/docker-build/docker-compose.yml | Uses AURON_DOCKER_PLATFORM to set the Compose service platform (with a default). |
| auron-build.sh | Adds --platform CLI parsing/validation and exports AURON_DOCKER_PLATFORM for Docker builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # ----------------------------------------------------------------------------- | ||
| USE_DOCKER=false | ||
| IMAGE_NAME="${SUPPORTED_OS_IMAGES[*]:0:1}" | ||
| DOCKER_PLATFORM="$DEFAULT_DOCKER_PLATFORM" |
| echo " --skiptests <true|false> Skip unit tests (default: true)" | ||
| echo " --sparktests <true|false> Run spark tests (default: false)" | ||
| echo " --docker <true|false> Build in Docker environment (default: false)" | ||
| echo " --platform <PLATFORM> Docker platform to use (default: linux/amd64)" |
Correct. I am trying to build an amd64 package on my local Mac. |
Which issue does this PR close?
Closes #2372
Rationale for this change
Docker build mode needs a way to specify the Docker platform from
auron-build.sh, especially on ARM hosts where release builds may need to run aslinux/amd64.What changes are included in this PR?
as title
Are there any user-facing changes?
no
How was this patch tested?
rebuild auron with docker mode