GH-50891: [C++][Parquet] DON'T MERGE NOW: Support FILE logical type - #50892
Open
HuaHuaY wants to merge 3 commits into
Open
GH-50891: [C++][Parquet] DON'T MERGE NOW: Support FILE logical type#50892HuaHuaY wants to merge 3 commits into
HuaHuaY wants to merge 3 commits into
Conversation
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
HuaHuaY
marked this pull request as ready for review
August 17, 2026 07:49
|
|
Contributor
Author
|
cc @brkyvz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Implement apache/parquet-format#585
The Parquet format supporting the
FILEtype has not yet been released, so the corresponding functionality cannot currently be merged into the Arrow repository.Since Arrow lacks specifications related to the
FILEtype, an Arrow extension type was defined to enable read-write round-trips for it.What changes are included in this PR?
parquet.thriftand the generated codeFILElogical typeI will split this PR into two after the new Parquet release is published.
Are these changes tested?
Yes.
Are there any user-facing changes?
cpp/src/parquet/types.h.cpp/src/arrow/extension/parquet_file.hand we can replace it at any time.