Fix Flight LargeList schema encoding#10298
Draft
yinli-systems wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
LargeListin Flight data encoder #10291.Rationale for this change
prepare_field_for_flightcurrently rebuildsDataType::LargeListfields withField::new_list, which changes the schema to a regularList. This silently loses the original large-list offset type in the Flight encoder's prepared schema.The existing
ListView/LargeListViewpath below this code already preserves the large variant, so this appears to be the same preservation rule missing forLargeList.What changes are included in this PR?
Field::new_large_listwhen preparingDataType::LargeListfields for Flight.LargeListfield, including field metadata and the nested item field.Are these changes tested?
Yes, locally with Rust 1.96.0 on macOS because the repository-pinned Rust 1.96.1 toolchain download was not completing cleanly in this environment.
RUSTUP_TOOLCHAIN=1.96.0-aarch64-apple-darwin cargo fmt --checkRUSTUP_TOOLCHAIN=1.96.0-aarch64-apple-darwin cargo test -p arrow-flight test_large_list_schema_encodedRUSTUP_TOOLCHAIN=1.96.0-aarch64-apple-darwin cargo test -p arrow-flight encode::testsgit diff --checkI used AI assistance to help inspect the nearby Flight schema-preparation paths and generate the focused regression test, then validated the change with the commands above.
Are there any user-facing changes?
Yes. Flight-encoded schemas now preserve
LargeListinstead of exposing it asListafter schema preparation.