Skip to content

rename Compression struct#10221

Merged
alamb merged 5 commits into
apache:mainfrom
Rich-T-kid:rich-T-kid/reuse-output-buffer
Jul 1, 2026
Merged

rename Compression struct#10221
alamb merged 5 commits into
apache:mainfrom
Rich-T-kid:rich-T-kid/reuse-output-buffer

Conversation

@Rich-T-kid

@Rich-T-kid Rich-T-kid commented Jun 26, 2026 •
edited by Jefffrey
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Changed Compression context to IPCwritecontext as now its holding onto the fbb and scratch space for buffers.

What changes are included in this PR?

  • compression.rs: Renamed CompressionContext → IpcWriteContext. Added scratch: Vec field (unused for now, #[allow(dead_code)]). Added #[deprecated(since = "57.0.0", note = "Use IpcWriteContext instead")] pub type CompressionContext = IpcWriteContext; for backward compatibility.
  • writer.rs: Updated all internal type references from CompressionContext -> IpcWriteContext. Renamed all field/parameter/variable occurrences of compression_context -> ipc_write_context. Both names are re-exported from writer so existing code compiles with a deprecation warning rather than a hard error.

Are these changes tested?

n/a

Are there any user-facing changes?

Deprecate old name, but no breaking changes

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Jun 26, 2026
@Rich-T-kid

Rich-T-kid commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

cc @alamb
a follow up PR will wire together the scratch buffer and the IPCsink enum together

@github-actions github-actions Bot added the arrow-flight Changes to the arrow-flight crate label Jun 27, 2026
@Jefffrey Jefffrey added api-change Changes to the arrow API and removed api-change Changes to the arrow API labels Jun 27, 2026
Jefffrey
Jefffrey reviewed Jun 27, 2026
View reviewed changes
Comment thread arrow-ipc/src/compression.rs Outdated
Comment thread arrow-ipc/src/compression.rs Outdated
Comment thread arrow-ipc/src/writer.rs Outdated
@Rich-T-kid
Rich-T-kid force-pushed the rich-T-kid/reuse-output-buffer branch from 04d576d to 801e3da Compare June 27, 2026 23:13
@Rich-T-kid

Rich-T-kid commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

@Jefffrey pushed up some revisions

@Rich-T-kid
Rich-T-kid force-pushed the rich-T-kid/reuse-output-buffer branch from 801e3da to 2958687 Compare June 27, 2026 23:15
@Rich-T-kid

Rich-T-kid commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

thanks @Jefffrey 🚀

@Jefffrey

Jefffrey commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

should be good to merge once its merged up from main

@alamb

alamb commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

I took the liberty of merging up from main to move this PR along

alamb
alamb reviewed Jul 1, 2026
View reviewed changes
Comment thread arrow-flight/src/encode.rs Outdated
data_gen: IpcDataGenerator,
dictionary_tracker: DictionaryTracker,
compression_context: CompressionContext,
compression_context: IpcWriteContext,

@alamb alamb Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also took the liberty of renaming these fields to match the new name in daa87ec.

@alamb
alamb merged commit 32bba5a into apache:main Jul 1, 2026
30 checks passed
@alamb

alamb commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

woohoo!

@Rich-T-kid

Rich-T-kid commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

thanks you @alamb & @Jefffrey 🚀

@alamb

alamb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Props to @Jefffrey as well

@alamb alamb mentioned this pull request Jul 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb left review comments
@Jefffrey Jefffrey Jefffrey approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rich-T-kid @Jefffrey @alamb